From 976b943e6a27bb8c4af0bdaa59a41b667203fffa Mon Sep 17 00:00:00 2001 From: Paul Gilzow Date: Mon, 9 Dec 2024 11:32:38 -0600 Subject: [PATCH 1/2] adds info logging when redirect response fails --- .github/actions/redirection-verification/index.js | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/.github/actions/redirection-verification/index.js b/.github/actions/redirection-verification/index.js index e4d58c5b89..18fab52212 100644 --- a/.github/actions/redirection-verification/index.js +++ b/.github/actions/redirection-verification/index.js @@ -95,6 +95,10 @@ const verify = async () => { return response } catch (reqerr) { //core.warning(`issue encountered with path ${path}!!! Returned status is ${reqerr.status}`) + // core.debug(`issue encountered with path ${path}!!! Returned status is ${reqerr.status}. More info: `) + // core.debug(reqerr.toJSON()) + core.info(`issue encountered with path ${path}!!! Returned status is ${reqerr.status}. More info: `) + core.info(reqerr.toJSON()) let row = [{data: linkify(path, axios.defaults.baseURL)},{data: linkify( anchors[path].to, axios.defaults.baseURL) }] tableData.push(row) } From 786f9337141762b4edd84fb81e40539a747fa300 Mon Sep 17 00:00:00 2001 From: Paul Gilzow Date: Mon, 9 Dec 2024 11:37:44 -0600 Subject: [PATCH 2/2] checks out the PR head sha for linting --- .github/workflows/linting.yaml | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/.github/workflows/linting.yaml b/.github/workflows/linting.yaml index 794aafeecc..6f56ca59f5 100644 --- a/.github/workflows/linting.yaml +++ b/.github/workflows/linting.yaml @@ -48,8 +48,13 @@ jobs: site: ['platform', 'upsun'] steps: - name: Checkout - uses: actions/checkout@v3 - + uses: actions/checkout@v4 + with: + # we need to checkout the PR repo/branch even if it's a fork because the action in the next step needs to + # check the markdown from the PR itself. Plus, we're only running this job if a PR from fork has been approved + fetch-depth: 0 + ref: ${{ github.event.pull_request.head.sha }} + - uses: ./.github/actions/redirection-verification - name: Vale uses: errata-ai/vale-action@reviewdog with: