From ebf382b464020c93a868bac23ae777f97328bf33 Mon Sep 17 00:00:00 2001 From: Paul Gilzow Date: Mon, 9 Dec 2024 13:17:14 -0600 Subject: [PATCH 1/6] removes extraneous call to redirection action --- .github/workflows/linting.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/linting.yaml b/.github/workflows/linting.yaml index 6f56ca59f5..973bd4e26c 100644 --- a/.github/workflows/linting.yaml +++ b/.github/workflows/linting.yaml @@ -54,7 +54,7 @@ jobs: # check the markdown from the PR itself. Plus, we're only running this job if a PR from fork has been approved fetch-depth: 0 ref: ${{ github.event.pull_request.head.sha }} - - uses: ./.github/actions/redirection-verification + - name: Vale uses: errata-ai/vale-action@reviewdog with: From 534cb00e7b98e6b43733742c63f4a6b0ea122109 Mon Sep 17 00:00:00 2001 From: Paul Gilzow Date: Mon, 9 Dec 2024 13:24:31 -0600 Subject: [PATCH 2/6] check to make sure the caught error is an axios error object --- .github/actions/redirection-verification/index.js | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/.github/actions/redirection-verification/index.js b/.github/actions/redirection-verification/index.js index 18fab52212..e2c79698c9 100644 --- a/.github/actions/redirection-verification/index.js +++ b/.github/actions/redirection-verification/index.js @@ -94,11 +94,15 @@ const verify = async () => { core.debug(`Response for our check of ${path} is ${response.status}`) return response } catch (reqerr) { - //core.warning(`issue encountered with path ${path}!!! Returned status is ${reqerr.status}`) // core.debug(`issue encountered with path ${path}!!! Returned status is ${reqerr.status}. More info: `) - // core.debug(reqerr.toJSON()) core.info(`issue encountered with path ${path}!!! Returned status is ${reqerr.status}. More info: `) - core.info(reqerr.toJSON()) + if(axios.isAxiosError(reqerr)) { + // core.debug(reqerr.toJSON()) + core.info(reqerr.toJSON()) + } else { + core.info(reqerr) + } + let row = [{data: linkify(path, axios.defaults.baseURL)},{data: linkify( anchors[path].to, axios.defaults.baseURL) }] tableData.push(row) } From e52630870ba7cd830768a856fd3157ad9bd3f172 Mon Sep 17 00:00:00 2001 From: Paul Gilzow Date: Mon, 9 Dec 2024 15:23:52 -0600 Subject: [PATCH 3/6] what the... what is going on?! --- .github/actions/redirection-verification/index.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/actions/redirection-verification/index.js b/.github/actions/redirection-verification/index.js index e2c79698c9..0193321259 100644 --- a/.github/actions/redirection-verification/index.js +++ b/.github/actions/redirection-verification/index.js @@ -100,7 +100,7 @@ const verify = async () => { // core.debug(reqerr.toJSON()) core.info(reqerr.toJSON()) } else { - core.info(reqerr) + core.info(JSON.stringify(reqerr)) } let row = [{data: linkify(path, axios.defaults.baseURL)},{data: linkify( anchors[path].to, axios.defaults.baseURL) }] From a9b64a1fde516009d8ff55f46d95752043a64afd Mon Sep 17 00:00:00 2001 From: Florent Huck Date: Tue, 10 Dec 2024 14:26:25 +0100 Subject: [PATCH 4/6] Next: command to start a Next.js app, using --- sites/upsun/src/get-started/stacks/nextjs.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sites/upsun/src/get-started/stacks/nextjs.md b/sites/upsun/src/get-started/stacks/nextjs.md index 55bbbba24c..3b52d5c424 100644 --- a/sites/upsun/src/get-started/stacks/nextjs.md +++ b/sites/upsun/src/get-started/stacks/nextjs.md @@ -203,7 +203,7 @@ applications: npm run build web: commands: - start: npm run start -p $PORT + start: "npx next start -p $PORT" upstream: socket_family: tcp locations: From 16536aca6ab08b910403d5b25d5d658af4ca0f05 Mon Sep 17 00:00:00 2001 From: Paul Gilzow Date: Tue, 10 Dec 2024 08:21:34 -0600 Subject: [PATCH 5/6] adds console.log to see which error this is --- .github/actions/redirection-verification/index.js | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/actions/redirection-verification/index.js b/.github/actions/redirection-verification/index.js index 0193321259..53f82e079c 100644 --- a/.github/actions/redirection-verification/index.js +++ b/.github/actions/redirection-verification/index.js @@ -100,6 +100,7 @@ const verify = async () => { // core.debug(reqerr.toJSON()) core.info(reqerr.toJSON()) } else { + console.log(reqerr) core.info(JSON.stringify(reqerr)) } From 3b6a7711c7ca83e4cc1e01a4e7af9573418193cd Mon Sep 17 00:00:00 2001 From: Paul Gilzow Date: Tue, 10 Dec 2024 08:41:04 -0600 Subject: [PATCH 6/6] cleans up whitespace --- .github/actions/redirection-verification/index.js | 3 --- 1 file changed, 3 deletions(-) diff --git a/.github/actions/redirection-verification/index.js b/.github/actions/redirection-verification/index.js index 53f82e079c..84eeb39806 100644 --- a/.github/actions/redirection-verification/index.js +++ b/.github/actions/redirection-verification/index.js @@ -112,11 +112,8 @@ const verify = async () => { Promise.all(validateRedirects).then(() => { if(tableData.length > 1) { - core.error('There was an error with one or more redirects.') - core.summary.addTable(tableData) - core.summary.write() core.setFailed('There was an error with one or more contracted redirects.') } else {