From 580156ec5a156d34b1c16e505bcdf4b7b1c3b1c0 Mon Sep 17 00:00:00 2001
From: Jon Chen <bsd@voltaire.sh>
Date: Wed, 7 Feb 2024 22:34:12 -0800
Subject: [PATCH 1/3] adds lolin s3 pro

---
 boards/lolin_s3_pro.json | 50 ++++++++++++++++++++++++++++++++++++++++
 1 file changed, 50 insertions(+)
 create mode 100644 boards/lolin_s3_pro.json

diff --git a/boards/lolin_s3_pro.json b/boards/lolin_s3_pro.json
new file mode 100644
index 000000000..714d412b6
--- /dev/null
+++ b/boards/lolin_s3_pro.json
@@ -0,0 +1,50 @@
+{
+  "build": {
+    "arduino": {
+      "ldscript": "esp32s3_out.ld",
+      "partitions": "default_16MB.csv",
+      "memory_type": "qio_opi"
+    },
+    "core": "esp32",
+    "extra_flags": [
+      "-DARDUINO_LOLIN_S3",
+      "-DBOARD_HAS_PSRAM",
+      "-DARDUINO_USB_MODE=1",
+      "-DARDUINO_USB_CDC_ON_BOOT=1",
+      "-DARDUINO_RUNNING_CORE=1",
+      "-DARDUINO_EVENT_RUNNING_CORE=1"
+    ],
+    "f_cpu": "240000000L",
+    "f_flash": "80000000L",
+    "flash_mode": "qio",
+    "hwids": [
+      [
+        "0x303A",
+        "0x8161"
+      ]
+    ],
+    "mcu": "esp32s3",
+    "variant": "lolin_s3"
+  },
+  "connectivity": [
+    "wifi",
+    "bluetooth"
+  ],
+  "debug": {
+    "openocd_target": "esp32s3.cfg"
+  },
+  "frameworks": [
+    "arduino",
+    "espidf"
+  ],
+  "name": "WEMOS LOLIN S3 PRO",
+  "upload": {
+    "flash_size": "16MB",
+    "maximum_ram_size": 327680,
+    "maximum_size": 16777216,
+    "require_upload_port": true,
+    "speed": 460800
+  },
+  "url": "https://www.wemos.cc/en/latest/s3/s3_pro.html",
+  "vendor": "WEMOS"
+}
\ No newline at end of file

From 482d56aaa6adab5faa52a0408dbffca1db4f2e20 Mon Sep 17 00:00:00 2001
From: Jon Chen <bsd@voltaire.sh>
Date: Wed, 7 Feb 2024 22:39:45 -0800
Subject: [PATCH 2/3] update build flag

---
 boards/lolin_s3_pro.json | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/boards/lolin_s3_pro.json b/boards/lolin_s3_pro.json
index 714d412b6..dc8e3ed02 100644
--- a/boards/lolin_s3_pro.json
+++ b/boards/lolin_s3_pro.json
@@ -7,7 +7,7 @@
     },
     "core": "esp32",
     "extra_flags": [
-      "-DARDUINO_LOLIN_S3",
+      "-DARDUINO_LOLIN_S3_PRO",
       "-DBOARD_HAS_PSRAM",
       "-DARDUINO_USB_MODE=1",
       "-DARDUINO_USB_CDC_ON_BOOT=1",

From 784f97f1bdc9c35e9bc67b683c1c93fa97725d9c Mon Sep 17 00:00:00 2001
From: Jon Chen <bsd@voltaire.sh>
Date: Thu, 8 Feb 2024 12:27:24 -0800
Subject: [PATCH 3/3] address comments

---
 boards/lolin_s3_pro.json | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/boards/lolin_s3_pro.json b/boards/lolin_s3_pro.json
index dc8e3ed02..4340aacc6 100644
--- a/boards/lolin_s3_pro.json
+++ b/boards/lolin_s3_pro.json
@@ -10,7 +10,6 @@
       "-DARDUINO_LOLIN_S3_PRO",
       "-DBOARD_HAS_PSRAM",
       "-DARDUINO_USB_MODE=1",
-      "-DARDUINO_USB_CDC_ON_BOOT=1",
       "-DARDUINO_RUNNING_CORE=1",
       "-DARDUINO_EVENT_RUNNING_CORE=1"
     ],
@@ -24,7 +23,7 @@
       ]
     ],
     "mcu": "esp32s3",
-    "variant": "lolin_s3"
+    "variant": "lolin_s3_pro"
   },
   "connectivity": [
     "wifi",
@@ -47,4 +46,4 @@
   },
   "url": "https://www.wemos.cc/en/latest/s3/s3_pro.html",
   "vendor": "WEMOS"
-}
\ No newline at end of file
+}