Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split into several packages for TLJH and BinderHub? #84

Open
jtpio opened this issue May 15, 2024 · 0 comments
Open

Split into several packages for TLJH and BinderHub? #84

jtpio opened this issue May 15, 2024 · 0 comments

Comments

@jtpio
Copy link
Member

jtpio commented May 15, 2024

Maybe we should document why we have to conditionally define the TLJH hooks?

Probably to allow for the package to be used with the BinderHub chart on Kubernetes? If so, maybe the tljh_repo2docker should continue to focus on the TLJH integration (be a TLJH plugin) as before, and have a separate package for use with BinderHub?

Originally posted by @jtpio in #83 (comment)
@jtpio jtpio mentioned this issue May 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jtpio