Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nativeauthenticator's page.html is overshadowed #58

Open
yamaton opened this issue Jun 8, 2022 · 3 comments
Open

nativeauthenticator's page.html is overshadowed #58

yamaton opened this issue Jun 8, 2022 · 3 comments

Comments

@yamaton
Copy link
Contributor

yamaton commented Jun 8, 2022

Hello, I'm running tljh-repo2docker with Native Authenticator. It runs fine, but some links at the top, "Change Password" and "Authorize Users", are gone.

I suppose this is because page.html in nativeauthenticator is overshadowed by the page.html in tljh-repo2docker.

Here is what you'd see if native authenticator is used alone:

@yamaton
Copy link
Contributor Author

yamaton commented Jun 9, 2022

After reading Extending Templates, I figured the {{ super() }} directive is missing in tljh-repo2docker's page.html.

Shall I prepare a PR?

@pierrepo
Copy link
Contributor

Hello @yamaton thanks for your input.

My understanding of tljh-repo2docker is that authentication is handled externally. So, I'm worried that allowing the Native Authenticator could be problematic with other integrations.

Do you have any thought on this @jtpio?

@jtpio
Copy link
Member

jtpio commented Jun 10, 2022

After reading Extending Templates, I figured the {{ super() }} directive is missing in tljh-repo2docker's page.html.

Ah that could be the case. Thanks @yamaton for catching this, feel free to open a PR to see if that can fix it..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants