Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactor] Clean up Tests #2

Open
Ben-G opened this issue Jan 22, 2018 · 1 comment
Open

[Refactor] Clean up Tests #2

Ben-G opened this issue Jan 22, 2018 · 1 comment
Assignees
@Ben-G
Labels
enhancement in-progress
Milestone
Next

Comments

@Ben-G
Copy link
Contributor

Ben-G commented Jan 22, 2018

The tests currently use a lot of parameterized tests which makes them difficult to read. We should refactor them and consider using BDD tests as throughout most of the PlanGrid codebase (though this means taking on Quick+Nimble as development and CI dependency).
@anayini anayini added this to the Mandatory milestone Jan 22, 2018
@Ben-G Ben-G mentioned this issue Jan 22, 2018
Merged
@Ben-G Ben-G removed this from the Initial Release milestone Jan 26, 2018
@Ben-G
Copy link
Contributor Author

Ben-G commented Jan 26, 2018

I've made enough progress here that I feel comfortable to remove this from the "Initial Release" milestone. Issue will remain open as there is still lots of room for improving the legacy tests.

@jessesquires jessesquires added this to the 0.2.0 milestone Feb 7, 2018
@benasher44 benasher44 modified the milestones: 0.2.0, 0.3.0 Sep 11, 2018
@benasher44 benasher44 modified the milestones: 0.3.0, 0.4.0 Sep 20, 2018
@jessesquires jessesquires modified the milestones: 0.4.0, Next Jan 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Ben-G Ben-G

Labels
enhancement in-progress
Projects
None yet
Milestone
Next
Development

No branches or pull requests
4 participants
@anayini @benasher44 @Ben-G @jessesquires