Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the option to configure automaticDiffingEnabled on TableViewDriver #157

Open
2 tasks done
anayini opened this issue Feb 28, 2019 · 3 comments
Open
2 tasks done

Comments

@anayini
Copy link
Contributor

anayini commented Feb 28, 2019

New issue checklist

General information

Can we remove the option to set automaticDiffingEnabled to false in TableViewDriver?

Now that we require diffingKeys in sections, it is not clear that it has much benefit and can lead to bugs.

@anayini anayini changed the title Remove the option to configure automaticDiffingEnabled Remove the option to configure automaticDiffingEnabled on TableViewDriver Feb 28, 2019
@jessesquires jessesquires added this to the Next milestone Feb 28, 2019
@jessesquires
Copy link
Contributor

Seems reasonable to me.

And "no-op" diffing for static views shouldn't have any perf issues. (If they do, sounds like a bug in diffing)

@jessesquires
Copy link
Contributor

This should let us delete a lot of code, too. 🔥

@anayini
Copy link
Contributor Author

anayini commented Mar 6, 2019

Update here - in my PR where I did this, I think it may have revealed a crash in DifferenceKit. Will try to see if I can repro a smaller case and if so, hand it off as an issue on DifferenceKit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants