From 1b3f712bf6b51d5c4ceaf584a68a320e35934e4e Mon Sep 17 00:00:00 2001 From: hyeon Date: Fri, 3 Nov 2023 12:42:22 +0900 Subject: [PATCH] Add explanation to FAV comparison --- .../GraphTypes/ActionQueryTest.cs | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/NineChronicles.Headless.Tests/GraphTypes/ActionQueryTest.cs b/NineChronicles.Headless.Tests/GraphTypes/ActionQueryTest.cs index d9b1088c9..54b0d79c5 100644 --- a/NineChronicles.Headless.Tests/GraphTypes/ActionQueryTest.cs +++ b/NineChronicles.Headless.Tests/GraphTypes/ActionQueryTest.cs @@ -1413,6 +1413,13 @@ public async Task ClaimItems(int claimDataCount) Assert.Equal(expectedFavList.Count, actualFavList.Count); for (var j = 0; j < expectedFavList.Count; j++) { + /* FIXME: Make Assert.Equal(FAV1, FAV2) works. + This test will fail because: + - GQL currency type does not allow `null` as minters to you should give empty list. + - But inside `Currency`, empty list is changed to null. + - As a result, currency hash are mismatch. + - See https://github.com/planetarium/NineChronicles.Headless/pull/2282#discussion_r1380857437 + */ // Assert.Equal(expectedFavList[i], actualFavList[i]); Assert.Equal(expectedFavList[j].Currency.Ticker, actualFavList[j].Currency.Ticker); Assert.Equal(expectedFavList[j].RawValue, actualFavList[j].RawValue);