-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem with new streams API #32
Comments
Confirmed on OS X 10.8 too. |
Same issue on windows too. |
Ditto on Linux. Same (recursive) issue with stream.resume and other work around that I have been trying also. |
Fix should be in: #33 --- thanks for the test case; that narrowed down why the other module was breaking. The issue wasn't the new streams interface, it was that Node 10 also made some changes to the EventEmitter. After tracing down that the EE was acting really wonky I went and found a commit in the Node code base (nodejs/node-v0.x-archive#4971) that described what they changed and how the EE had to be created. However, then several things had to be changed to make it work. |
I'm still seeing this behaviour with the latest version (1.0.11) on node v0.10.11 - with at least one module anyway (https://github.com/rvagg/node-levelup). ie - there's no output. It works fine with lazy in v0.8.x If I comment out the |
Forget my last comment, wrapping the stream using |
I can't quite figure out what's causing this, but I've got a reproducible testcase (on my OS X machine, anyway).
Sample file:
On 0.8
On 0.10
I tried calling
stream.resume()
to force it into old stream mode, but this kicked it into an infinite loop (stack limit reached) outputting the first item repeatedly.Discovered by @swestcott
The text was updated successfully, but these errors were encountered: