Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display Stats and Issue Publication Date not matching locale #90

Open
bokamm opened this issue May 7, 2024 · 1 comment
Open

Display Stats and Issue Publication Date not matching locale #90

bokamm opened this issue May 7, 2024 · 1 comment
Assignees

Comments

@bokamm
Copy link

bokamm commented May 7, 2024

Describe the bug
Using two locales (English and Japanese), the frontend does not pick up translations for months in the download stats of an article or the publication date of an issue (see screenshots).

To Reproduce
Steps to reproduce the behavior:

  1. Activate additional locale/language
  2. Check frontend.

Expected behavior
The publication date in Japanese should be 2024年5月1日 not 2024 May 1.
The download graph should display Japanese months as in the locale language file (1月 2月 3月 etc., not Jan Feb Mar etc.).

Screenshots
Publication date in Japanese
pubdate_ja

Publication date in English
pupdate_en

Downloads in Japanese
downloads_ja

System Information:

  • OJS 3.4.0.5
  • Immersion Theme 1.1.2.2
  • PHP 8.2.6

Browsers:
Safari, Chrome, Firefox, DuckDuckGo (all newest versions, on macOS 14.4.1

Additional context
I translated the plugin on weblate into Japanese, please integrate in future releases: https://translate.pkp.sfu.ca/projects/plugins/immersion/ja/
(I installed my translation locally for testing)

@asmecher
Copy link
Member

Thanks, @bokamm! @Vitaliy-1, adding to your list to consider.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants