Skip to content
This repository has been archived by the owner on Sep 11, 2022. It is now read-only.

left/rightView autosizing #94

Open
jasonmccreary opened this issue Feb 2, 2013 · 9 comments
Open

left/rightView autosizing #94

jasonmccreary opened this issue Feb 2, 2013 · 9 comments

Comments

@jasonmccreary
Copy link
Contributor

I can't seem to figured out the autosizing. I've tried setting minWidth and maxWidth without luck.

In my case, the left view controller is a table view. By default the disclosure indicators are behind the front view controller unless I enter presentation mode. In which case the entire left view controller is visible.

The desired experience would be that the left view is sized correctly at all times. So the disclosures appear in both reveal and presentation mode.

I can get it to work in one or the other modes, but not both with the appropriate animated transition. View the current Facebook app for a UX reference. There seems to be a lot of code, it's possible this functionality exists. However, an example would be appreciated.

@nashfive
Copy link

nashfive commented Feb 5, 2013

I get the same problem...
My leftViewController is a UITableViewController and my frontViewController is a UINavigationController presenting my mainViewController.
Setting minWidth/maxWidth on the leftViewController has no effect, the FrontViewController always slides to the same position and I can't see my UITableView's cells disclosures...

@jasonmccreary
Copy link
Contributor Author

I'm new to PKRevealController. I assumed after digging around the .m I was just missing something. However, maybe it doesn't have this resizing out of the box. I hoped pkluz would comment before I made a pull-request.

@skinkwork
Copy link

this was happening for me until I realised that the default width ranges for the left and right views are set in a method that gets called when the reveal controller's view is loaded. I am submitting a pull request to pkluz to fix this issue.

@jasonmccreary
Copy link
Contributor Author

Can you link the pull request?

@skinkwork
Copy link

#101

@jasonmccreary
Copy link
Contributor Author

What are the new navigation controller properties?

@mmarszal
Copy link

I've been also experiencing this. For me, I have a UITableViewController within a UINavigationController as my leftViewController. However upon revealing it, the rightmost UIBarButtonItem is cut off from the frontviewController. I'd like to see the entire leftviewcontroller without having to enter presentation mode. I looked at idlepixel's 101 pull request, but i Don't anything there to fix this problem. Can anyone lead me to a solution?

@elsurudo
Copy link

I believe I have a similar issue. My left view seems to be as wide as the whole screen, and thus obscured by the front view controller when shown. Note that I am calling [self.revealController setMinimumWidth:340.0f maximumWidth:340.0f forViewController:self]; in my left view controller's viewDidLoad...

Any workarounds?

@alvaroloes
Copy link

Hi! I had the same issue, so I created a pull request to fix it. It sets the with of the left and right views to the values returned by [self leftViewMaxWidth] and [self rightViewMaxWidth].
Here it is: #236

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants