Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How about release MINE check when loading files? #66

Open
14725 opened this issue May 5, 2022 · 0 comments
Open

How about release MINE check when loading files? #66

14725 opened this issue May 5, 2022 · 0 comments

Comments

@14725
Copy link

14725 commented May 5, 2022

Since now the browser knows more and more media formats, and the decoding in fact doesn't refer to MINEs, why not release or remove the file MINE checking?


It really brings troubles. For example my mobile refuses to load WAV until this 'if' got crossed out.

https://github.com/pkalogiros/AudioMass/blob/production/src/engine.js#L148

Maybe it's because my mobile uses audio/x-wav or something else, but I'm not sure.


In addition the removal of this check also allow the AudioMass to extract audio from a video, which could be a new feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant