Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some events are not properly defined. #25

Open
pjcalvo opened this issue Sep 26, 2023 · 0 comments
Open

Some events are not properly defined. #25

pjcalvo opened this issue Sep 26, 2023 · 0 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@pjcalvo
Copy link
Owner

pjcalvo commented Sep 26, 2023

Some events that we currently handle are not properly defined an thus we should fix them to make sure the code is clean:

For example:

 def test_stop(self, user_count=None, environment: Environment =None) -> None:
        self.__register_event(self.node_id, 0, 'test_stopped')

If we look at the code from locust this event does not trigger neither user_count nor environment, so there params are basically useless:

test_stop: EventHook
"""
Fired on each node when a load test is stopped.
"""

Please only look at those that we currently support. To add new events it is better to separate into new issues.

@pjcalvo pjcalvo added good first issue Good for newcomers help wanted Extra attention is needed labels Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant