Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add python typings #19

Open
pjcalvo opened this issue Sep 18, 2023 · 3 comments · Fixed by #24
Open

Add python typings #19

pjcalvo opened this issue Sep 18, 2023 · 3 comments · Fixed by #24
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@pjcalvo
Copy link
Owner

pjcalvo commented Sep 18, 2023

Would be nice to have typings as much as possible at least on the function parameters so that we can feel safer about modifying code.
@pjcalvo pjcalvo added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Sep 18, 2023
@issamansur
Copy link
Contributor

issamansur commented Sep 18, 2023 •
edited
Loading

I add parameters and rewriting some places.
Pull request: #23

@pjcalvo
Copy link
Owner Author

pjcalvo commented Sep 18, 2023

Will take a look

@issamansur issamansur mentioned this issue Sep 26, 2023
Merged
@issamansur
Copy link
Contributor

@pjcalvo You can close this issue) it didn't cloase automatically(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactoring, add types
2 participants
@pjcalvo @issamansur