Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tilemap index buffer is re-created on every change for big tilemaps, causing performance issues. #168

Open
nicolasalt opened this issue Nov 22, 2024 · 1 comment
Open

Tilemap index buffer is re-created on every change for big tilemaps, causing performance issues. #168

nicolasalt opened this issue Nov 22, 2024 · 1 comment

Comments

@nicolasalt
Copy link

The issue seems to be caused by this code https://github.com/pixijs/tilemap/blame/main/src/TilemapPipe.ts#L116 that doesn't make sense: the "while" loop is never executed, so the buffer is extended to the exact new length.

Image

The bug comes from this PR: b3f1288
@ivanpopelyshev
Copy link
Collaborator

ivanpopelyshev commented Nov 22, 2024 •
edited
Loading

oh right, it has to be this.ibLen

and then this len has to be used instead of totalIndices

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ivanpopelyshev @nicolasalt