You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Add a new stale boolean attribute to TemporaryPanelEntry and FormPanelEntry, and a new reducer method invalidatePanels , for updating all current forms and panels to stale = true
We will need to pass the connected tabId as a prop into the sidebar component
Render the “Panel not available on this Page” overlay over the temporary and form panel body. Close button should trigger closing the panel.
Test Plan:
Ensure that this not occur on SPA navigation (ex. on a github repo, switching from the Code to Pull Requests tab.
If a link opens a new tab, the old tab’s sidebar panels should not be marked as stale
Ensure that this occurs when refreshing the page
Navigating via new link in the browser or following a link.
Feature UX: use the provided UX mockup https://www.figma.com/file/iK3zlhXpXqjPCX8jgriynh/SideBar?type=design&node-id=1748-3224&mode=design&t=SjRFqEO49OZWGfmF-4
Engineering Considerations/Implementation Sketch
Render the “Panel not available on this Page” overlay over the temporary and form panel body. Close button should trigger closing the panel.
Test Plan:
From: https://www.notion.so/pixiebrix/Phase-gracefully-handle-page-reload-navigation-in-the-Chromium-Side-Panel-0efdedb6c1e44b088e65106202e08c28?pvs=4#ec3a3eef571a4be988dcee641ee86759
The text was updated successfully, but these errors were encountered: