From 3053e30154c65a92ee6e8276517d48dcad5fc091 Mon Sep 17 00:00:00 2001 From: Eduardo Date: Thu, 4 Jul 2024 14:44:27 -0400 Subject: [PATCH] fix flaky expectation --- .../tests/regressions/welcomeStarterBricks.spec.ts | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/end-to-end-tests/tests/regressions/welcomeStarterBricks.spec.ts b/end-to-end-tests/tests/regressions/welcomeStarterBricks.spec.ts index 45b9f3badd..becf805dd3 100644 --- a/end-to-end-tests/tests/regressions/welcomeStarterBricks.spec.ts +++ b/end-to-end-tests/tests/regressions/welcomeStarterBricks.spec.ts @@ -31,12 +31,14 @@ test("#8740: can view the starter mods on the pixiebrix.com/welcome page", async await modActivationPage.clickActivateAndWaitForModsPageRedirect(); await page.goto("https://pixiebrix.com/welcome"); + // eslint-disable-next-line playwright/no-networkidle -- Ensure page and content script is done loading + await page.waitForLoadState("networkidle"); await runModViaQuickBar(page, "Open Sidebar"); const sideBarPage = await getSidebarPage(page, extensionId); await expect( sideBarPage.getByRole("heading", { name: "Announcements" }), - ).toBeVisible({ timeout: 8000 }); + ).toBeVisible(); await expect( sideBarPage.getByRole("heading", { name: "Decision Tree" }), ).toBeVisible();