-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ESLint Plugin Import - prefer-default-export #96
Comments
I tried enabling this, there are 165 errors in the extension. While I always use this rule, I don’t think it would be well-liked https://github.com/pixiebrix/pixiebrix-extension/actions/runs/6439735844/job/17487763557 |
This was added as a result of a comment on an old PR: pixiebrix/pixiebrix-extension#6115 (comment) It's not a priority. I'll discuss it with the engineering team before we move forward. With the number of errors, we'd likely make it a warning first if we move forward with it at all. |
Alternatively, we could enforce only named exports using https://github.com/import-js/eslint-plugin-import/blob/main/docs/rules/no-default-export.md. I'm not strongly tied to either approach, just looking for consistency. |
I'd say |
Looks like the team prefers Not a priority to fix. I support turning it on as a warning for now. |
https://github.com/import-js/eslint-plugin-import/blob/main/docs/rules/prefer-default-export.md
The text was updated successfully, but these errors were encountered: