Enforce the exhaustive deps for our custom hooks

[twschiller]

Context

• We use some custom hooks that have deps like useEffect: useAsyncState and useAsyncEffect (which is a library)
• We use an eslint plugin for enforcing exhaustive deps for useEffect and useCallback: https://reactjs.org/docs/hooks-rules.html
• A missing dependency can cause subtle bugs

Implementation Sketch

• Use the advanced configuration to add the hooks to eslint: https://www.npmjs.com/package/eslint-plugin-react-hooks#advanced-configuration

[twschiller]

Issues impacting this ticket:

• exhaustive-deps: custom effects should support async functions facebook/react#19034

[grahamlangford]

@twschiller this could be a good issue to finally implement before the Page Editor refactor

[twschiller]

@twschiller this could be a good issue to finally implement before the Page Editor refactor

Your call on relative prioritization. Personally, I wouldn't block on it

[grahamlangford]

Wouldn't block. Just one I'll try to work in