Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@typescript-eslint/naming-convention configuration #5

Open
fregante opened this issue Mar 3, 2022 · 2 comments
Open

@typescript-eslint/naming-convention configuration #5

fregante opened this issue Mar 3, 2022 · 2 comments

Comments

@fregante
Copy link
Collaborator

fregante commented Mar 3, 2022

I dropped this rule because it's too complex and incomplete. If we want to enforce some naming conventions with the linter I suggest we use someone else's config and stick to it without exceptions or else we (I) will end up doing this:

Unfortunately the biggest drawback of Sindre Sorhus’ configuration for this rule excludes UPPER_SNAKE_CASE, which you might not like.

From https://github.com/pixiebrix/pixiebrix-app/pull/1246#discussion_r811072628

Related:

@fregante
Copy link
Collaborator Author

fregante commented Mar 3, 2022

Presumably we could find one like Sindre Sorhus and then tweak it for some naming conventions we care about?

The issue is the config is lengthy and it doesn't lend itself to quick fixes, especially because it's hard to figure out what a specific value will and will not allow in practice.

Basically I don’t think it's worth spending time tweaking it manually and frustrate other developers until we find perfection. If possible I'd take the Prettier way and just go with it.

I'll try other configurations on the extension and see what matches our style the most.

@fregante fregante assigned fregante and unassigned fregante Feb 23, 2024
@fregante
Copy link
Collaborator Author

I thought that the recommended config included by @typescript-eslint/naming-convention would work for us, but 1085 errors (also no ALL_UPPERCASE allowed)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant