Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Review] Gallery image sizes check #23

Open
cristianfrumusanu opened this issue Apr 19, 2017 · 6 comments
Open

[Review] Gallery image sizes check #23

cristianfrumusanu opened this issue Apr 19, 2017 · 6 comments

Comments

@cristianfrumusanu
Copy link
Contributor

Something is going on with gallery pages. The large image is being loaded instead of the thumbnail, which has a big impact on bandwidth, without the user's permission.

ref: https://themes.trac.wordpress.org/ticket/41040#comment:1

@cristianfrumusanu
Copy link
Contributor Author

@vladolaru

Aici intr-adevar se pare ca fortam imaginea sa fie mai mare decat o cere user-ul.
De exemplu daca din post editor este setata ca o galerie sa aiba thumb-uri, cand este vizualizat post-ul apar toate imaginile full-size si nu mi-am dat seama unde-i codul care face sa se intample asta.

@cristianfrumusanu
Copy link
Contributor Author

@vladolaru
Ai timp sa arunci un ochi aici?

@vladolaru
Copy link
Contributor

@cristianfrumusanu Pai uite de aici e buba https://github.com/pixelgrade/noah-lite/blob/lite/inc/extras.php#L359 ca fortam atributele galeriilor peste tot, nu doar pentru proiecte asa cum ar trebui. O rezolv, dar asta implica bube pentru ca galeriile se intind mult orizontal si apar spatieri uriase cand sunt thumbnailuri. @georgeolaru Ce zici?

@georgeolaru
Copy link
Member

@vladolaru ideea initiala a fost ca galeriile sa se comporte la fel peste tot — pe proiecte, pagini si posturi. Cred ca asta poate sa ramana la nivel de sugestie din partea ei si sa o ignoram, atat timp cat galeria arata bine si cu imagini mai mici.

@vladolaru
Copy link
Contributor

@georgeolaru Ok. Revert :)

@georgeolaru
Copy link
Member

:) oke — a ajutat si faptul ca a clarificat tipul ala ca multe din chestii sunt recomandari (uneori subiective?).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants