From 1440e6958ead86879578f0beca9745886d6e62f8 Mon Sep 17 00:00:00 2001 From: Lalit Kumar Bhasin Date: Mon, 25 Nov 2024 12:24:15 -0800 Subject: [PATCH] Remove async-trait crate as dependency for traces (#2339) --- opentelemetry-sdk/Cargo.toml | 2 +- opentelemetry-sdk/src/trace/span_processor.rs | 2 -- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/opentelemetry-sdk/Cargo.toml b/opentelemetry-sdk/Cargo.toml index 39928fecb3..bf03c8d34a 100644 --- a/opentelemetry-sdk/Cargo.toml +++ b/opentelemetry-sdk/Cargo.toml @@ -43,7 +43,7 @@ pprof = { version = "0.13", features = ["flamegraph", "criterion"] } [features] default = ["trace", "metrics", "logs", "internal-logs"] -trace = ["opentelemetry/trace", "rand", "async-trait", "percent-encoding"] +trace = ["opentelemetry/trace", "rand", "percent-encoding"] jaeger_remote_sampler = ["trace", "opentelemetry-http", "http", "serde", "serde_json", "url"] logs = ["opentelemetry/logs", "async-trait", "serde_json"] spec_unstable_logs_enabled = ["logs", "opentelemetry/spec_unstable_logs_enabled"] diff --git a/opentelemetry-sdk/src/trace/span_processor.rs b/opentelemetry-sdk/src/trace/span_processor.rs index 97f3ad851b..4d6f0df814 100644 --- a/opentelemetry-sdk/src/trace/span_processor.rs +++ b/opentelemetry-sdk/src/trace/span_processor.rs @@ -727,7 +727,6 @@ mod tests { OTEL_BSP_MAX_CONCURRENT_EXPORTS_DEFAULT, OTEL_BSP_MAX_EXPORT_BATCH_SIZE_DEFAULT, }; use crate::trace::{BatchConfig, BatchConfigBuilder, SpanEvents, SpanLinks}; - use async_trait::async_trait; use opentelemetry::trace::{SpanContext, SpanId, SpanKind, Status}; use std::fmt::Debug; use std::future::Future; @@ -963,7 +962,6 @@ mod tests { } } - #[async_trait] impl SpanExporter for BlockingExporter where D: Fn(Duration) -> DS + 'static + Send + Sync,