Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set RPATH for install target #588

Merged
merged 3 commits into from
Nov 29, 2024
Merged

Set RPATH for install target #588

merged 3 commits into from
Nov 29, 2024

Conversation

lgrz
Copy link
Contributor

@lgrz lgrz commented Nov 29, 2024

Incremental fix for #242, set the runtime path so that the cli tools can find libtbb when building PISA with the libtbb submodule which is the default option.

  • Set RPATH
  • Add install step to the cli test build
  • Typo fix for benchmark option

lgrz added 3 commits November 26, 2024 17:30
During install set RPATH so that libtbb can be found when building
with the oneTBB submodule.
The following programs in the tools directory require libtbb:

- compress_inverted_index
- evaluate_queries
- invert
- parse_collection
- partition_fwd_index
- reorder-docids
- shards

See pisa-engine#242
Add step to install tools in default path before running tests (pisa-engine#242).
@elshize elshize self-requested a review November 29, 2024 14:26
Copy link
Member

@elshize elshize left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff, thanks!

@elshize elshize merged commit fffd1c9 into pisa-engine:master Nov 29, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants