Fix codacy warnings

pisa-engine · Dec 21, 2023 · 35330c4 · 35330c4
1 parent a1ed47b
commit 35330c4
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/include/pisa/intersection.hpp b/include/pisa/intersection.hpp
@@ -23,7 +23,7 @@ namespace intersection {
     using Mask = std::bitset<MAX_QUERY_LEN_EXP>;
 
     /// Returns a filtered copy of `query` containing only terms indicated by ones in the bit mask.
-    [[nodiscard]] inline auto filter(Query const& query, Mask mask) -> Query {
+    [[nodiscard]] inline auto filter(Query const& query, Mask const& mask) -> Query {
         if (query.terms.size() > MAX_QUERY_LEN) {
             throw std::invalid_argument("Queries can be at most 2^32 terms long");
         }

diff --git a/include/pisa/wand_data_compressed.hpp b/include/pisa/wand_data_compressed.hpp
@@ -27,7 +27,8 @@ class uniform_score_compressor {
               m_num_docs((num_docs + 1) << quantization_bits.as_int()),
               m_docs_sequences(params) {}
 
-        std::vector<uint32_t> compress_data(std::vector<float> effective_scores, float max_score) {
+        std::vector<uint32_t>
+        compress_data(std::vector<float> const& effective_scores, float max_score) {
             // Partition scores.
             LinearQuantizer quantizer(max_score, m_quantization_bits.as_int());
             std::vector<uint32_t> score_indexes;

diff --git a/tools/reorder_docids.hpp b/tools/reorder_docids.hpp
@@ -7,7 +7,7 @@
 
 namespace pisa {
 
-auto reorder_docids(ReorderDocuments args) -> int {
+auto reorder_docids(ReorderDocuments const& args) -> int {
     tbb::global_control c(oneapi::tbb::global_control::max_allowed_parallelism, 2);
     try {
         if (args.bp()) {