Focus change does not filter pending tabs or applies closing tab

[SlugFiller]

Suspend tab is nice enough to allow configuring which tab to focus if the current tab is suspended. As part of its options, it allows skipping suspended tabs. This is pretty nice, because it means tabs aren't loaded if you don't want them to. But it has two problems:

1. It considers "pending" tabs as not being suspended. Tabs with the "pending" attribute are tabs loaded with Session Manager, or Firefox's built-in session restore, which were not yet focused, and hence not loaded, to save up on start up time. They should be treated like a manually suspended tab. (Testing for the "pending" attribute on the tab should be pretty simple)
2. It applies to suspending the selected tab, but does nothing for closing the selected tab. This creates a rift between the behaviors of these two very similar actions.

Apologies if this should have been opened as two separate issues, but they seem very closely related.

[piroor]

It applies to suspending the selected tab, but does nothing for closing the selected tab. This creates a rift between the behaviors of these two very similar actions.

I think this is hard to be fixed because this is a bootstrapped (restartless) addon. To keep addon dynamically uninstallable, we must use only public APIs of Firefox e.g. "TabClose" event. However, Firefox changes tab selection before a "TabClose" event is fired, and we cannot know the changing tab selection is triggered by a closing of the current tab or not...

[piroor]

And I think 96e0f6c improves the behavior partially.

[SlugFiller]

Regarding that commit, shouldn't the line if (tabs.length > 0) be if (focusableTabs.length > 0)?

I'm assuming the desired behavior is that if all other tabs are pending, then the nearest/most appropriate pending tab is selected.

[piroor]

Regarding that commit, shouldn't the line if (tabs.length > 0) be if (focusableTabs.length > 0)?

Oops!

[piroor]

The commit 25cd63e fixes my mistake...