Add a script that generates the .d.ts files based on current documentation #538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, we took a look at the PR and we appreciate the effort you put into it but at the moment we don't want to rely on the we're currently working towards doing a general release of the typescript client soon which would alleviate this issue. thank you for putting the effort into it, it's much appreciated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supposedly fixes #340
I've noticed that
openapi-generator-cliwas making a file with class names that do not match some of the exported classes. The documentation in the other hand is quite accurate, it just have few issues like inconstant case style.With that in mind I decided to write a tiny script that converts the documentation to a .d.ts file. I think it's a decent alternative while waiting for actual typescript definition or bigger fixes in the code to have classes that matches the open-api docs :)