fix:issue#1212 candidate with empty string

[scorpionknifes]

Description

based on #1428 (comment)

merge after pion/ice accept nil candidate pion/ice#315 (comment)

thx @DevRockstarZ for PR #1428

Reference issue

Fixes #1212

[Sean-Der]

@scorpionknifes this looks great to me! I would be happy to take this today :)

• Can you squash this down into one commit
• I would make you the author, and then use Co-authored-by:
• You have a few linter errors

[Sean-Der]

@scorpionknifes pion/[email protected] is tagged!

[codecov]

Codecov Report

Merging #1584 (a869563) into master (236b6c4) will decrease coverage by 0.02%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master    #1584      +/-   ##
==========================================
- Coverage   75.10%   75.08%   -0.03%     
==========================================
  Files          79       79              
  Lines        5612     5619       +7     
==========================================
+ Hits         4215     4219       +4     
- Misses       1025     1026       +1     
- Partials      372      374       +2     

Flag	Coverage Δ
go	76.69% <66.66%> (-0.03%)	⬇️
wasm	70.42% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
icetransport.go	68.66% <ø> (ø)
peerconnection.go	74.28% <66.66%> (-0.11%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 236b6c4...a869563. Read the comment docs.

[scorpionknifes]

I'm gonna need to take a deeper look

[Sean-Der]

If think if you move your test into peerconnection_go_test.go it will work! It is just being run for WASM also currently.

For the race I would update t *ICETransport) AddRemoteCandidate( to accept a *ICECandidate and that will make your life easier. The lifecycle of the ICEAgent is messy.

[scorpionknifes]

Anyway, I can cover this by setting agent=nil in test?

[Sean-Der]

Merged with 3eb51d8

Fantastic work @scorpionknifes really appreciate all the work you have been doing lately? Do you have a Twitter? I would love to give you a shout out for all the great work you are doing (if not will just do your GitHub)