From 5d7c2bf74f2827a3218d28cff744c37bf5453ce2 Mon Sep 17 00:00:00 2001 From: Sean DuBois Date: Mon, 18 Mar 2024 13:14:44 -0400 Subject: [PATCH] Remove unused member in SCTPTransport RTOMax wasn't actually being stored, is being pulled directly from SettingEngine --- sctptransport.go | 5 +---- settingengine.go | 2 +- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/sctptransport.go b/sctptransport.go index 5c2071aac81..26cee487ff8 100644 --- a/sctptransport.go +++ b/sctptransport.go @@ -58,8 +58,6 @@ type SCTPTransport struct { api *API log logging.LeveledLogger - // maximum retransmission timeout - rtoMax float64 } // NewSCTPTransport creates a new SCTPTransport. @@ -107,13 +105,12 @@ func (r *SCTPTransport) Start(SCTPCapabilities) error { if dtlsTransport == nil || dtlsTransport.conn == nil { return errSCTPTransportDTLS } - rtoMax := float64(r.api.settingEngine.sctp.rtoMax) / float64(time.Millisecond) sctpAssociation, err := sctp.Client(sctp.Config{ NetConn: dtlsTransport.conn, MaxReceiveBufferSize: r.api.settingEngine.sctp.maxReceiveBufferSize, EnableZeroChecksum: r.api.settingEngine.sctp.enableZeroChecksum, LoggerFactory: r.api.settingEngine.LoggerFactory, - RTOMax: rtoMax, + RTOMax: float64(r.api.settingEngine.sctp.rtoMax) / float64(time.Millisecond), }) if err != nil { return err diff --git a/settingengine.go b/settingengine.go index f529914a4a2..f121d050b6a 100644 --- a/settingengine.go +++ b/settingengine.go @@ -434,7 +434,7 @@ func (e *SettingEngine) SetSCTPMaxReceiveBufferSize(maxReceiveBufferSize uint32) e.sctp.maxReceiveBufferSize = maxReceiveBufferSize } -// SetSCTPZeroChecksum enables the zero checksum feature in SCTP. +// EnableSCTPZeroChecksum controls the zero checksum feature in SCTP. // This removes the need to checksum every incoming/outgoing packet and will reduce // latency and CPU usage. This feature is not backwards compatible so is disabled by default func (e *SettingEngine) EnableSCTPZeroChecksum(isEnabled bool) {