Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose MarshalSize as a public interface function #165

Merged
merged 1 commit into from
Dec 9, 2023

Conversation

asnyatkov
Copy link
Contributor

@asnyatkov asnyatkov commented Dec 7, 2023

Description

Length of the packet is an important piece of information which can be used for stats reporting and to calculate size or pre-allocated memory buffers.

@asnyatkov asnyatkov changed the title Expose Len as a public interface function Expose MarshalSize as a public interface function Dec 8, 2023
Copy link

codecov bot commented Dec 9, 2023

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (546aef8) 76.52% compared to head (753fdb5) 76.08%.

Files Patch % Lines
compound_packet.go 0.00% 6 Missing ⚠️
extended_report.go 0.00% 2 Missing ⚠️
raw_packet.go 0.00% 2 Missing ⚠️
rfc8888.go 66.66% 1 Missing ⚠️
transport_layer_cc.go 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #165      +/-   ##
==========================================
- Coverage   76.52%   76.08%   -0.45%     
==========================================
  Files          21       21              
  Lines        2407     2421      +14     
==========================================
  Hits         1842     1842              
- Misses        470      484      +14     
  Partials       95       95              
Flag Coverage Δ
go ?
wasm 76.08% <72.72%> (-0.45%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Lenth of the packet is an important piece of information which can
be used for stats reporting and to calculate size or pre-allocated
memory buffers.
@Sean-Der Sean-Der merged commit 9a47c5e into pion:master Dec 9, 2023
13 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants