Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need help #122

Open
vbo75 opened this issue May 31, 2022 · 5 comments
Open

Need help #122

vbo75 opened this issue May 31, 2022 · 5 comments

Comments

@vbo75
Copy link

vbo75 commented May 31, 2022

Hi,
I tried to understand the meta model implemented in the postit.json and postitDi.json and I've got some questions

  • I didn't find any reference on attributs isReadOnly, isVirtual and subsettedProperty in moddle doc, are they implemented or just unused attributs ?
  • whats the difference between PostitRootBoard and PostitPlane, why using this to elements for encapsulate drawing elements ? can we mix them into a unique element ?

Thanks a lot for your help and congratulation for your work.

@pinussilvestrus
Copy link
Owner

pinussilvestrus commented Jun 1, 2022

Hi @vbo75, thanks for your request!

The moddle meta Schema was basically adopted from the existing bpmn-moddle. It's very likely that there are unused properties related to the BPMN 2.0 spec that are not used anywhere in this project. If that's the case, let's clean them up 👍. I'm open for contributions though 👍

Regarding the difference of PostitRootBoard and PostitPlane: same reason as bpmn-js was the project this one got adapted from. The BPMN 2.0 spec allowes multiple planes inside a root element, to potentially switch between them visually. That's why both exist. post-it-js currently does not support this.

@vbo75
Copy link
Author

vbo75 commented Jun 10, 2022

Hi,
Thanks for your answer.
I refactored the project to support multiple planes for one board.
So by now, there's only one board that defines postit elements and their attributes like name, title, date...
And one or more plane that define postit DI like bounds, color, ... and RefId to postit element.
One postit element can have multiple DI, depends on the plane selected for drawing shapes.
In that case, for creating shapes, instead of walking through the board (because there is no more reference to a DI), I'm walking through DIs define in the selected plan and add busniessObject for each DI element but as busniessObject has also a DI attribute, it creates a refence loop...
So I'm asking me if it's necessary to keep businessObject ?

Thanks for your help.

@pinussilvestrus
Copy link
Owner

Thanks for your details! That's an implementation detail for sure. As I'm interested: is there a specific reason for you to make those changes? Maybe sharing some information about your use case would help me to understand 🙂

@vbo75
Copy link
Author

vbo75 commented Jun 26, 2022

Hi,
Here is my use case:
The postit board defines businessObject and those businessObject can be used in different planes. A businesObject can have a different shape for each plane, each shape defined by a specific Di moddle element for this plane.

So, through PostitTreeWalke, for each businessObject find in the board, a shape element is created with Di moddle element definition. I attached businessObject and diObject both directly as references to shape object and there is no more need to have a reference to Di moddle element in the businessObject.

@pinussilvestrus
Copy link
Owner

Thanks for your insights. That's highly technical though, can you share a real-world use case on why you need those architecture changes? What do you want to achieve? Is this something related to having different post-it boards on a single page?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants