Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for WebVTT subtitles embedded in webm files #19

Open
ale5000-git opened this issue Mar 20, 2021 · 7 comments
Open

Add support for WebVTT subtitles embedded in webm files #19

ale5000-git opened this issue Mar 20, 2021 · 7 comments

Comments

@ale5000-git
Copy link

ale5000-git commented Mar 20, 2021

Sample file: https://gofile.io/d/2jbaFN
This fork of LAVFilters support it:
https://github.com/clsid2/LAVFilters

It is included in K-Lite Codec Pack 16.0.9.

Ref: #18

Could you please add support for WebVTT subtitles embedded in webm files?

@pinterf
Copy link
Owner

pinterf commented Mar 20, 2021

Well, O.K., I made it to recognize the WebVTT format but no formatting is supported. (and as I see neither does it MPC-HC with the above sample)
It would be nice that as a minimum formatter tags must to be omitted. Leaving the bare text.
Info for myself: https://w3c.github.io/webvtt/#webvtt-cue-class-span
Writing a parser for that is not a two minutes task - at least not for me :)

@clsid2
Copy link
Contributor

clsid2 commented Mar 20, 2021

MPC-HC converts a few tags to SSA format, and strips a few unsupported ones.

For example see last few commits from today:
https://github.com/clsid2/mpc-hc/commits/develop

@pinterf
Copy link
Owner

pinterf commented Mar 21, 2021

Great, thank you clsid2, it's a hot topic, I'll then wait a bit.

@ale5000-git
Copy link
Author

ale5000-git commented Mar 27, 2021

@pinterf: The latest MPC-HC plus this pull request already has a considerable support.

@pinterf
Copy link
Owner

pinterf commented Mar 27, 2021

Yep, the earlier changes were already integrated, still waiting a bit to settle down.

@ale5000-git
Copy link
Author

Can this be considered done or there is something missing?

@pinterf
Copy link
Owner

pinterf commented Oct 5, 2021

I think it is considered done, except that I haven't checked since March whether it was developed further in MPC-HC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants