Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deadlock #10

Open
clsid2 opened this issue May 23, 2019 · 2 comments
Open

Deadlock #10

clsid2 opened this issue May 23, 2019 · 2 comments

Comments

@clsid2
Copy link
Contributor

clsid2 commented May 23, 2019

There is a deadlock that sometimes occurs while unloading VSFilter. It happens when at same time SetupFRD function is called from inside the loop in CDirectVobSubFilter::ThreadProc().

Related commit, which only partially fixed it:
Cyberbeing/xy-VSFilter@d7ccef2

One solution would be to remove the lock inside the destructor CDirectVobSubFilter::~CDirectVobSubFilter()

To reproduce use MPC-HC with subtitle renderer set to VSFilter and a couple videos that don't have subtitles. Then quickly keep loading files (e.g. with PageUp/PageDown) and eventually it will hang.

@pinterf
Copy link
Owner

pinterf commented Mar 5, 2021

Just returned to the project, do you know whether this one was fixed already? Is it serious/really needs investigation?
Yes, i know, the project is between dead/half-dead.

@clsid2
Copy link
Contributor Author

clsid2 commented Mar 5, 2021

Nope, not fixed afaik. It was pretty easy to trigger if I remember correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants