Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore: refine split code for both compacted sst files and logs #56917

Merged
merged 10 commits into from
Nov 7, 2024

Conversation

3pointer
Copy link
Contributor

@3pointer 3pointer commented Oct 28, 2024

What problem does this PR solve?

Issue Number: ref #56522

This is the first PR split from #54813.

Problem Summary:
Focus on restore compacted sst files

What changed and how does it work?

This PR primarily makes the following adjustments:

  1. Removal of Log Split: The log splitting logic has been removed, simplifying the code structure and making future usage more convenient.

  2. Unified Split Logic: The splitting logic for SST files and log files has been unified, allowing both to share the same logic, reducing code duplication and improving maintainability.

  3. Facilitates Future Extensions: This unified approach makes it easier to extend and modify the handling of SST and log files in the future, enhancing the flexibility of the code.

Overall, these changes lead to a cleaner codebase with clearer logic, laying a solid foundation for future development and maintenance.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 28, 2024
Copy link

tiprow bot commented Oct 28, 2024

Hi @3pointer. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented Oct 28, 2024

Codecov Report

Attention: Patch coverage is 68.36555% with 180 lines in your changes missing coverage. Please review.

Project coverage is 58.4577%. Comparing base (c7d09e6) to head (1634163).
Report is 90 commits behind head on master.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #56917         +/-   ##
=================================================
- Coverage   73.3187%   58.4577%   -14.8611%     
=================================================
  Files          1636       1811        +175     
  Lines        453659     663069     +209410     
=================================================
+ Hits         332617     387615      +54998     
- Misses       100668     250127     +149459     
- Partials      20374      25327       +4953     
Flag Coverage Δ
integration 40.7983% <45.8699%> (?)
unit 73.5099% <67.3110%> (+0.9794%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9478% <ø> (ø)
parser ∅ <ø> (∅)
br 62.0579% <68.3655%> (+16.0462%) ⬆️

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 1, 2024
@3pointer
Copy link
Contributor Author

3pointer commented Nov 4, 2024

/test pull-br-integration-test

Copy link

tiprow bot commented Nov 4, 2024

@3pointer: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test pull-br-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@3pointer
Copy link
Contributor Author

3pointer commented Nov 4, 2024

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Nov 4, 2024
Copy link

tiprow bot commented Nov 4, 2024

@3pointer: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
fast_test_tiprow 1634163 link true /test fast_test_tiprow

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@3pointer
Copy link
Contributor Author

3pointer commented Nov 5, 2024

/test pull-br-integration-test

Copy link

tiprow bot commented Nov 5, 2024

@3pointer: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test fast_test_tiprow
  • /test fast_test_tiprow_ddlargsv1
  • /test tidb_parser_test

Use /test all to run the following jobs that were automatically triggered:

  • fast_test_tiprow
  • tidb_parser_test

In response to this:

/test pull-br-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 6, 2024
Copy link

ti-chi-bot bot commented Nov 6, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-01 03:08:59.519004101 +0000 UTC m=+578452.358159639: ☑️ agreed by YuJuncen.
  • 2024-11-06 06:01:57.497599358 +0000 UTC m=+1020830.336754904: ☑️ agreed by Leavrth.

Copy link

ti-chi-bot bot commented Nov 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: D3Hunter, Leavrth, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot merged commit ef6662e into pingcap:master Nov 7, 2024
32 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants