-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore: refine split code for both compacted sst files and logs #56917
Restore: refine split code for both compacted sst files and logs #56917
Conversation
Hi @3pointer. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #56917 +/- ##
=================================================
- Coverage 73.3187% 58.4577% -14.8611%
=================================================
Files 1636 1811 +175
Lines 453659 663069 +209410
=================================================
+ Hits 332617 387615 +54998
- Misses 100668 250127 +149459
- Partials 20374 25327 +4953
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Co-authored-by: 山岚 <[email protected]>
/test pull-br-integration-test |
@3pointer: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
@3pointer: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/test pull-br-integration-test |
@3pointer: The specified target(s) for
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: D3Hunter, Leavrth, YuJuncen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What problem does this PR solve?
Issue Number: ref #56522
This is the first PR split from #54813.
Problem Summary:
Focus on restore compacted sst files
What changed and how does it work?
This PR primarily makes the following adjustments:
Removal of Log Split: The log splitting logic has been removed, simplifying the code structure and making future usage more convenient.
Unified Split Logic: The splitting logic for SST files and log files has been unified, allowing both to share the same logic, reducing code duplication and improving maintainability.
Facilitates Future Extensions: This unified approach makes it easier to extend and modify the handling of SST and log files in the future, enhancing the flexibility of the code.
Overall, these changes lead to a cleaner codebase with clearer logic, laying a solid foundation for future development and maintenance.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.