Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify first-time user's start #193

Open
mensch72 opened this issue Oct 4, 2022 · 5 comments
Open

simplify first-time user's start #193

mensch72 opened this issue Oct 4, 2022 · 5 comments
Assignees
Labels
angular Probably needs Angular-related skills feature A new feature or enhancement hacktoberfest ready to implement Sufficiently detailed to start working on --> place in "Issues" typescript Probably needs Typescript-related skills
Milestone

Comments

@mensch72
Copy link
Collaborator

mensch72 commented Oct 4, 2022

When being invited to a poll, a first-time vodle user should be presented with the poll's welcome page immediately rather than with the login page. Such a user should be able to use the main parts of the voting gui without having to log in first. Only for transmitting their waps they should be required to log in.

In particular, the voting gui (=poll page) for a non-logged-in invited user should:

  • disable the "live results", "agreement details", "add option", and "delegate" buttons
  • present a privacy agreement checkbox as an overlay at the bottom of the page
  • disable sliders as long as the privacy agreement checkbox is not checked
  • show a banner at the top explaining that assigned waps are only getting effective after logging in, and presenting a two login buttons: "guest login" and "personal login"
  • show the login page as an overlay when clicking these buttons
  • do not submit any waps to the poll database before user is logged in

In addition, the login page could also be shortened by skipping the language selection whenever the browser specifies a preferred language that is supported by vodle.

@mensch72 mensch72 added feature A new feature or enhancement ready to implement Sufficiently detailed to start working on --> place in "Issues" typescript Probably needs Typescript-related skills angular Probably needs Angular-related skills labels Oct 4, 2022
@mensch72 mensch72 added this to the First Release milestone Oct 4, 2022
@kata-kas
Copy link

Hello! Can I work on this one? 🚀

@mensch72
Copy link
Collaborator Author

Dear @catalin-casuneanu , of course! Thank you so much!

It will be some work I guess though...

The most relevant code parts are here (*.page.ts and *.page.html are relevant):

Some more things:

  • The checkbox, text, and link for the privacy statement in the overlay at the bottom should be the same as on the login page.
  • The login page for returning users should stay as it is, but we may be able to make the same code also work in an overlay to the poll page for first-time users, to avoid redundant code?

@kata-kas
Copy link

kata-kas commented Oct 28, 2022

Thank you for the information!
I'm experiencing some errors on setup, because I'm on a M1 Macbook, so I will uninstall node-sass (which is deprecated anyway) and install sass to fix it.
I can then switch back before I create a PR, if you don't want to switch to sass instead of node-sass permanently.
More details on the error here

@mensch72
Copy link
Collaborator Author

Good to know, hopefully that won't break any dependencies.

@mensch72
Copy link
Collaborator Author

Happy holidays, @catalin-casuneanu ! Are you making progress? Do you need anything from me?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
angular Probably needs Angular-related skills feature A new feature or enhancement hacktoberfest ready to implement Sufficiently detailed to start working on --> place in "Issues" typescript Probably needs Typescript-related skills
Projects
None yet
Development

No branches or pull requests

2 participants