Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Users can form delegation cycles, if so, max wap on cycle is used #156

Open
mensch72 opened this issue Jul 1, 2022 · 1 comment
Open
Assignees
Labels
feature A new feature or enhancement ready to implement Sufficiently detailed to start working on --> place in "Issues" typescript Probably needs Typescript-related skills
Milestone

Comments

@mensch72
Copy link
Collaborator

mensch72 commented Jul 1, 2022

Currently, delegation is turned off since we originally wanted to prevent cycles but failed to, causing weird effects.

Task: write logics in delegation.service and poll.service that can deal with cycles and will use the maximum of the waps on the cycle. Then allow delegation again.

@mensch72 mensch72 added feature A new feature or enhancement ready to implement Sufficiently detailed to start working on --> place in "Issues" typescript Probably needs Typescript-related skills labels Jul 1, 2022
@mensch72 mensch72 added this to the First Release milestone Jul 1, 2022
@mensch72 mensch72 self-assigned this Jul 1, 2022
@adrian-lison
Copy link

Do I understand correctly: the plan is to allow cycles, i.e. if for a certain option there is a set of voters that represent a cycle in the delegation graph, we take the biggest wap out of all waps that the voters have set for this option before delegation (I guess this simply follows the general strategy of going towards a concensus by default)? And if I delegate right from the start, my default wap is taken? Do we somehow want to draw the users' attention to this?
The good thing is that for every option, each node can only be part of one delegation cycle, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A new feature or enhancement ready to implement Sufficiently detailed to start working on --> place in "Issues" typescript Probably needs Typescript-related skills
Projects
None yet
Development

No branches or pull requests

2 participants