Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is this package deprecated, should we switch to IdentityServer.Hangfire.Console or another fork? #127

Open
ian-a-anderson opened this issue Dec 27, 2023 · 3 comments

Comments

@ian-a-anderson
Copy link

I have used this package for years but am wondering if I should be switching to a fork for continued use? I have specifically hit an issue where Hangfire.Console.Extensions has switched over to using IdentityStream.Hangfire.Console as their underlying source.

Since Hangfire.Console was originally developed by @pieceofsummer I just wanted to see if there was any official guidance on the future of this package or if users should look elsewhere for continued updates and use.

Thanks!

@AnderssonPeter
Copy link

AnderssonPeter commented Feb 26, 2024

I switched just because there was no lifesigns here and I fully understand why as the maintainer most likely has other issues like the war in Ukraine (go Ukraine go).

But if IdentityStream.Hangfire.Console would create a PR with their changes to this repo and they got merged I would switch my nuget to target this again!

@khellang Any chance you could provide one or more PR's now that @pieceofsummer seems to be active again before the code bases drift apart?

@khellang
Copy link

khellang commented Feb 28, 2024

First of all, I'm happy the project is (and hopefully will stay) alive again 😄

We did a pretty hard fork with a bunch of modernization on the code in addition to cherry-picking a few pending bug fixes. Creating a PR would likely lead to a massive diff that's hard to review.

But by any means, if @pieceofsummer is up for it, I'll gladly send a PR 😄

@pieceofsummer
Copy link
Owner

@khellang I can make you a maintainer if you wish )
I have little to no free time to spare on it anyway.

But I hate the idea of randomly bumping dependency versions beyond the minimal necessary ones. E.g. if SerializationHelper was added in 1.7.0 and you're eager to use it, then the dependency should be 1.7.0, not some random semi-latest one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants