Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Remove liquidity from a single asset #31

Closed
5 of 7 tasks
MickdeGraaf opened this issue May 22, 2020 · 3 comments · Fixed by #48
Closed
5 of 7 tasks

[Feature] Remove liquidity from a single asset #31

MickdeGraaf opened this issue May 22, 2020 · 3 comments · Fixed by #48
Assignees

Comments

@MickdeGraaf
Copy link
Member

MickdeGraaf commented May 22, 2020

User Story

  • As an <audience/user>: User
  • I want to <action/task>: Remove my liquidity in a single asset
  • so that <outcome/goal/benefit>: So I don't have to liquidate all the unwanted assets

Type

  • Enhancement
  • Maintenance
  • Refactor

Definition of Done

  • function exitswapPoolAmountIn(uint poolAmountIn, address tokenOut)
  • function exitswapExternAmountOut(address tokenOut, uint tokenAmountOut)
  • Test coverage in unit test
  • Tested in mainnet test

Attach files or screenshots if it's helpful for this issue.

Reference implementation: https://github.com/balancer-labs/smart-pools/blob/master/crp/contracts/ConfigurableRightsPool.sol

@dmvt
Copy link
Contributor

dmvt commented Jun 1, 2020

https://forum.piedao.org/t/bounty-program-votes/118/2
PieDAO governance has voted to approve this issue for a bounty:
Approved Scope: 8 - 16 hours (2795.2 - 5590.4 $DOUGH)
Contributor: @travisdmathis

@travisdmathis
Copy link
Contributor

Leaving these as done until I can be paid out for them

@MickdeGraaf
Copy link
Member Author

Implemented in #51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants