Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Throw error on unsupported methods from configurable rights pool #27

Closed
5 of 7 tasks
MickdeGraaf opened this issue May 21, 2020 · 3 comments · Fixed by #44
Closed
5 of 7 tasks

[Feature] Throw error on unsupported methods from configurable rights pool #27

MickdeGraaf opened this issue May 21, 2020 · 3 comments · Fixed by #44
Assignees

Comments

@MickdeGraaf
Copy link
Member

MickdeGraaf commented May 21, 2020

User Story

  • As an <audience/user>: A dev integrating the Pie Smart Pools
  • I want to <action/task>: Know that these methods are not supported
  • so that <outcome/goal/benefit>: So I don't wonder why it's not working

Type

  • Enhancement
  • Maintenance
  • Refactor

Definition of Done

  • Throw error on: function finalizeSmartPool()
  • Throw error on: function createPool()
  • Errors clearly state that function is not supported
  • Test errors in unit test

Attach files or screenshots if it's helpful for this issue.

Reference Implementations:

@dmvt
Copy link
Contributor

dmvt commented Jun 1, 2020

https://forum.piedao.org/t/bounty-program-votes/118/2
PieDAO governance has voted to approve this issue for a bounty:
Approved Scope: 4 - 8 hours (1397.6 - 2795.2 $DOUGH)
Contributor: @travisdmathis

@travisdmathis
Copy link
Contributor

leaving in done until disbursement

@MickdeGraaf
Copy link
Member Author

Implemented in #51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants