Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GM Mask creation #4

Open
armenbod opened this issue Mar 25, 2024 · 1 comment
Open

GM Mask creation #4

armenbod opened this issue Mar 25, 2024 · 1 comment

Comments

@armenbod
Copy link

In the code, it takes the pv gm mask from the structural data if none is supplied:

wsp.log.write(" - Taking GM ROI from segmentation of structural image\n")
wsp.enable_gm_roi = Image((wsp.structural.gm_pv.data > 0).astype(np.int32), header=wsp.structural.struc.header)

In Shirzadi2018, they say they are using a 70% probability threshold for GM from which they define the mask, but in this code no threshold is used. How does this affect the output quality score? Do we need to consider a threshold?

@mcraig-ibme
Copy link
Contributor

I agree this looks very dubious. It is using the GM partial volume which will be > 0 in many voxels with very little GM.

The original shell code this was based on used the FAST segmentation directly which is more sensible but doesn't correspond to the 70% threshold either (it will count a voxel as GM if GM is the largest PV which will typically mean > 50%).

I suspect the intention here was to use gm_seg rather than gm_pv which would give a 50% threshold. The python code was based on the shell scripts not the original paper!

I will run a test case using current code and then thresholds of 0.5 and 0.7 to see the effect on the amount of GM detected and the quality measures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants