Bug occuring with way values are being fixed in enable code

[armenbod]

When getting combined quality score there is this snippet:

oxasl_enable/oxasl_enable/enable.py

Lines 299 to 301 in a44d4f9

	# Try to ensure numerical errors do not affect the result
	vals[vals == np.inf] = 0
	vals[vals == -np.inf] = 0

However vals is a list, not a numpy array, so the behaviour of this code is not right. A toy example would be:

vals = [2, 3, np.inf]
vals[vals == np.inf] = 0
vals[vals == -np.inf] = 0

print(vals)

>>> [0, 3, inf]

Can be fixed either by converting to numpy array or changing to list comprehension:

vals = np.array([2, 3, np.inf])
vals[vals == np.inf] = 0
vals[vals == -np.inf] = 0

print(vals)

>>> [2, 3, 0]

or

vals = [2, 3, np.inf]

vals = [0 if x == np.inf else x for x in vals]
vals = [0 if x == -np.inf else x for x in vals]

print(vals)

>>> [2, 3, 0]

[mcraig-ibme]

Agreed, will fix in bitbucket and here