Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reduce the test timings #56

Open
mariev opened this issue Mar 10, 2021 · 3 comments
Open

reduce the test timings #56

mariev opened this issue Mar 10, 2021 · 3 comments
Labels
future work nice to have change, work on this later

Comments

@mariev
Copy link
Collaborator

mariev commented Mar 10, 2021

validate_sequence tests currently run ~60s which need to be shortened. Are there any tests that can be skipped, esp. when migrating to CRAN
@mariev mariev added the future work nice to have change, work on this later label Mar 10, 2021
@thebioengineer
Copy link
Collaborator

The longest sequence is the validate_sequence series of tests. Functionally, I think we can skip the first two (source and build) because they do get run by the install.

@mariev
Copy link
Collaborator Author

mariev commented Mar 31, 2021 •
edited
Loading

I am starting to identify an exemplar integration test that should be preserved for CRAN as I write new tests. Is adopting a strategy of skipping diagnostic units on CRAN reasonable?

@mariev
Copy link
Collaborator Author

mariev commented Apr 22, 2021

any tests checking pdf contents, including the rendering step rmarkdown::render can be suppressed on CRAN

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
future work nice to have change, work on this later
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mariev @thebioengineer