Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update argument names "pkg" to path #35

Open
mariev opened this issue Mar 3, 2021 · 6 comments
Open

update argument names "pkg" to path #35

mariev opened this issue Mar 3, 2021 · 6 comments

Comments

@mariev
Copy link
Collaborator

mariev commented Mar 3, 2021

In addition to playing nicely with #34 implementation of config file vt_use_validation will need to be updated to handle case when validation folder lives outside of vignettes.

Two additional use cases to address:

  1. author includes validation folder in something besides vignettes, but still within pkg. E.g. inst/ or vignettes/something/validation
  2. author places validation folder outside package
@mariev
Copy link
Collaborator Author

mariev commented Mar 3, 2021

@thebioengineer vt_use_validation_config also seems to expect a package as top level. How will this play with case 2 ☝️ ?

@thebioengineer
Copy link
Collaborator

The actual function should operate okay, it will create a .validation folder at the path identified, and add a .here as well.

@thebioengineer thebioengineer mentioned this issue Mar 3, 2021
34 tasks
@mariev
Copy link
Collaborator Author

mariev commented Mar 3, 2021

so we just need to update argument names? It looks like the .validation config file is using "path".

@thebioengineer
Copy link
Collaborator

I think for most of the functions it would be updating the argument pkg to be path. I've tried to be consistent with functions that interface with the user so it should be a matter of just replacing. but lets do that once we have most of these PR's closed

@mariev mariev changed the title vt_use_validation update argument names "pkg" to path Mar 24, 2021
@mariev
Copy link
Collaborator Author

mariev commented May 8, 2021

@thebioengineer where do we stand on this?

@thebioengineer
Copy link
Collaborator

still to do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants