Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vt_scrape_tags_from assumes all files within the validation/* folder to be viable to be scraped from. #186

Open
thebioengineer opened this issue Aug 18, 2021 · 0 comments
Open

vt_scrape_tags_from assumes all files within the validation/* folder to be viable to be scraped from. #186

thebioengineer opened this issue Aug 18, 2021 · 0 comments
Labels
bug Something isn't working future work nice to have change, work on this later

Comments

@thebioengineer
Copy link
Collaborator

valtools/R/scrape_authors.R

Line 50 in 595c343

dir_ref_files <- list.files(dir_ref,recursive = TRUE,full.names = TRUE)

this line assumes that all files within the specified dir are reasonable to parse - which is not reasonable always. Ie. Supplementary files living within those folders.
@thebioengineer thebioengineer added bug Something isn't working future work nice to have change, work on this later labels Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working future work nice to have change, work on this later
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@thebioengineer