Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for 'ignore' list in the URL checker #6

Open
epijim opened this issue Dec 29, 2023 · 2 comments
Open

Support for 'ignore' list in the URL checker #6

epijim opened this issue Dec 29, 2023 · 2 comments
Assignees
Labels
question Further information is requested

Comments

@epijim
Copy link
Collaborator

epijim commented Dec 29, 2023

Do we support a an 'ignore' list for URLs?

Based on here I don't think so: https://github.com/phuse-org/devops-toolkit/blob/main/.github/workflows/urlchecker.yml#L47

Assuming it's not supported - I've removed the comment about lycheeignore currently in the site, which I assume is an old dependency we don't use now.

@epijim epijim added the question Further information is requested label Dec 29, 2023
@cicdguy
Copy link
Collaborator

cicdguy commented Dec 29, 2023

I'd argue that there shouldn't be an ignore list at all. When CRAN investigates URLs, they don't ignore certain URLs or ask authors which URLs they should ignore. If there are invalid or non-conformant URLs, they should be simply removed from the packages.

@bms63
Copy link
Collaborator

bms63 commented Jan 5, 2024

We have a slack 502 link that CRAN lets by, but I've been wondering if there is another way to have the slack link display in our README.

I've noticed that CRAN lets things by and then wallops you later!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants