Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crash on first class callable as conditional do while #12246

Open
samsonasik opened this issue Dec 11, 2024 · 4 comments · May be fixed by phpstan/phpstan-src#3752
Open

crash on first class callable as conditional do while #12246

samsonasik opened this issue Dec 11, 2024 · 4 comments · May be fixed by phpstan/phpstan-src#3752
Labels
bug
Milestone
Easy fixes

Comments

@samsonasik
Copy link

Bug report

given code:

final class SkipFirstClassCallableInDo
{
    public function getSubscribedEvents()
    {
        do {

        } while ($this->textElement(...));
    }

    public function textElement()
    {
         return 1;
    }
}

it cause crash:

Call to undefined method PHPStan\Node\Printer\Printer::pPHPStan_Node_MethodCallableNode()

Code snippet that reproduces the problem

https://phpstan.org/r/178ac73a-e99c-4961-957f-a3c6062d7c44

Expected output

it should not crash.

Did PHPStan help you today? Did it make you happy in any way?

No response
@samsonasik samsonasik mentioned this issue Dec 11, 2024
Merged
@samsonasik samsonasik linked a pull request Dec 22, 2024 that will close this issue
Open
@ondrejmirtes ondrejmirtes added this to the Easy fixes milestone Jan 16, 2025
@phpstan-bot
Copy link
Contributor

@samsonasik After the latest push in 2.1.x, PHPStan now reports different result with your code snippet:

@@ @@
--1: Call to undefined method PHPStan\Node\Printer\Printer::pPHPStan_Node_MethodCallableNode()
+No errors

@samsonasik
Copy link
Author

It still crash, see https://phpstan.org/r/c3c5e55c-b6eb-473a-ab88-8a9649a8871f

@phpstan-bot
Copy link
Contributor

@samsonasik After the latest push in 2.1.x, PHPStan now reports different result with your code snippet:

@@ @@
--1: Call to undefined method PHPStan\Node\Printer\Printer::pPHPStan_Node_MethodCallableNode()
+No errors

@samsonasik
Copy link
Author

it is not, is the website up to date with phpstan bot?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
Easy fixes
Development

Successfully merging a pull request may close this issue.

Fix crash on MethodCallableNode on do while samsonasik/phpstan-src
3 participants
@ondrejmirtes @samsonasik @phpstan-bot