-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated to latest update fom 3/21/2023, and I don't see any of my groups in Panorama View #141
Comments
If you open the console in the panorama view and reload the page, does any errors appear? Could you try disabling the add-on and then re-enable it in the extensions settings? |
Good question. How do I open the console in Panorama? Now I see one group with all the tabs squished into it. Where does this extension save its group data to, which file? I can pull another one from backup if need be, and compare how the extension behaves with the old file. |
For console: Right click on the page -> Inspect (Q) -> Then select the Console The data is stored in the window and tab's session storage, so I would guess the data is in the file "sessionstore.jsonlz4" in the Firefox profile folder. It sounds to me like the session storage got erased somehow. |
So I checked the console, didn't see anything specifically when i re-loaded this page, other than "[NoScript]:0 Prompt Hook installation #141". I tried re-loading with the sessionstore.jsonl4z from a known good backup, and get the same issue. So I think it's the upgrade to the new version of the tab groups script that maybe did it. |
It happened to me for the first time ever this morning. All tabs in one group. |
Yeah it seems to be a repeatable issue here for me. I just now exited out of Firefox, restarted my system, and opened Firefox to find that all the tab groups have again disappeared. The tabs are all there, but the groups have either disappeared or there is one group of a few tabs (out of the many that I see in the drop-down menu on the right). |
Also, a bunch of tabs have somehow become "hidden" tabs. |
EDIT: the comment below was meant for issue #142 , please disregard it here. OK, I think I identified the culprit: the Firefox extension "Select After Closing Current". When I disabled it, now I get the expected behavior. Apparently this is known to the writers of the "Select After Closing Current" extension: "Update: From Firefox 65, this extension can prevent the browser's default selection, so flashing, Ctrl+Tab order changes and tab discarding incompatibility are fixed. Firefox 65 is the current Developer Edition and will be released on 2019-01-29. Update: If there are problems with tab grouping extensions (e.g. Simple Tab Groups, Panorama View), see these compatibility options in v4.0. After closing a tab that is currently selected, Firefox usually moves the focus to the tab on the right. This extension can change this behavior and select another tab according to the preference instead." |
Same problem here. But I don't have the Firefox extension "Select After Closing Current". To me it seems this happend during a reboot and not when I closed the browser myself. |
@harry-g oh, I'm sorry, that "Select After Closing Current" was meant in response to another issue I had reported. Yeah Firefox just doesn't appear to re-open the tabs in the tab groups. I dunno what's going on. |
The only things I can think of that could suddenly cause this are:
I would assume it's number 2 and, I don't know why it didn't occur to be before but, I should have added a mutex lock on the group cache object and save function. |
I will try to get a new version out next week. I really wish Firefox would hurry up and get itself a standard tab groups API soon so I didn't have to do all this hacky emulation anymore.. :'( |
I still see the tabs when I click on the down-arrow on the right of the Firefox menu bar, but when I switch to Panorama view, I get an empty group where there should be three or four groups full of tabs.
The text was updated successfully, but these errors were encountered: