Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated to latest update fom 3/21/2023, and I don't see any of my groups in Panorama View #141

Open
roeyk opened this issue Mar 22, 2023 · 12 comments
Labels

Comments

@roeyk
Copy link

roeyk commented Mar 22, 2023

I still see the tabs when I click on the down-arrow on the right of the Firefox menu bar, but when I switch to Panorama view, I get an empty group where there should be three or four groups full of tabs.

@photodiode
Copy link
Owner

photodiode commented Mar 22, 2023

If you open the console in the panorama view and reload the page, does any errors appear?
I'm really curious as to what could have caused this.

Could you try disabling the add-on and then re-enable it in the extensions settings?

@roeyk
Copy link
Author

roeyk commented Mar 22, 2023

Good question. How do I open the console in Panorama? Now I see one group with all the tabs squished into it. Where does this extension save its group data to, which file? I can pull another one from backup if need be, and compare how the extension behaves with the old file.

@photodiode
Copy link
Owner

photodiode commented Mar 22, 2023

For console: Right click on the page -> Inspect (Q) -> Then select the Console

The data is stored in the window and tab's session storage, so I would guess the data is in the file "sessionstore.jsonlz4" in the Firefox profile folder.

It sounds to me like the session storage got erased somehow.

@roeyk
Copy link
Author

roeyk commented Mar 23, 2023

So I checked the console, didn't see anything specifically when i re-loaded this page, other than "[NoScript]:0 Prompt Hook installation #141". I tried re-loading with the sessionstore.jsonl4z from a known good backup, and get the same issue. So I think it's the upgrade to the new version of the tab groups script that maybe did it.

@photodiode
Copy link
Owner

It happened to me for the first time ever this morning. All tabs in one group.
The frustrating part is I have no idea why all tabs and windows would suddenly lose their group value.
I did upgrade Firefox to v111.0 yesterday, maybe that is what caused this..? Seems weird.

@roeyk
Copy link
Author

roeyk commented Mar 28, 2023

Yeah it seems to be a repeatable issue here for me. I just now exited out of Firefox, restarted my system, and opened Firefox to find that all the tab groups have again disappeared. The tabs are all there, but the groups have either disappeared or there is one group of a few tabs (out of the many that I see in the drop-down menu on the right).

@roeyk
Copy link
Author

roeyk commented Mar 28, 2023

Also, a bunch of tabs have somehow become "hidden" tabs.

@roeyk
Copy link
Author

roeyk commented Mar 28, 2023

EDIT: the comment below was meant for issue #142 , please disregard it here.

OK, I think I identified the culprit: the Firefox extension "Select After Closing Current". When I disabled it, now I get the expected behavior. Apparently this is known to the writers of the "Select After Closing Current" extension:

"Update: From Firefox 65, this extension can prevent the browser's default selection, so flashing, Ctrl+Tab order changes and tab discarding incompatibility are fixed. Firefox 65 is the current Developer Edition and will be released on 2019-01-29.

Update: If there are problems with tab grouping extensions (e.g. Simple Tab Groups, Panorama View), see these compatibility options in v4.0.

After closing a tab that is currently selected, Firefox usually moves the focus to the tab on the right. This extension can change this behavior and select another tab according to the preference instead."

@harry-g
Copy link

harry-g commented Mar 31, 2023

Same problem here.
Firefox 111.01 on Mac.
Lost all tab groups 2 times already.

But I don't have the Firefox extension "Select After Closing Current".

To me it seems this happend during a reboot and not when I closed the browser myself.
But just a guess.
Or it could be when I had several Windows open, which was formerly no problem by reopening the one with tab groups with "recently closed windows".

@roeyk
Copy link
Author

roeyk commented Mar 31, 2023

@harry-g oh, I'm sorry, that "Select After Closing Current" was meant in response to another issue I had reported.

Yeah Firefox just doesn't appear to re-open the tabs in the tab groups. I dunno what's going on.

@photodiode
Copy link
Owner

The only things I can think of that could suddenly cause this are:

  1. Sometimes Firefox closes before the saveGroups function could finish (I find that weird)
  2. Something changed so that a race condition with the group cache became more frequent

I would assume it's number 2 and, I don't know why it didn't occur to be before but, I should have added a mutex lock on the group cache object and save function.
The cache is obviously being used asynchronously from different functions.

photodiode added a commit that referenced this issue Mar 31, 2023
@photodiode
Copy link
Owner

I will try to get a new version out next week.

I really wish Firefox would hurry up and get itself a standard tab groups API soon so I didn't have to do all this hacky emulation anymore.. :'(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants