phonon 1.4.4, fixed #44, #46 and #52

phonon-framework · Dec 20, 2015 · a7eae58 · a7eae58
1 parent ba39be8
commit a7eae58
Show file tree

Hide file tree

Showing 24 changed files with 204 additions and 121 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,11 @@
+### 1.1.4 (2015-12-20)
+
+#### Bug Fixes
+
+* strange horizontal scroll with side panels on Android 5+ [#44](https://github.com/quark-dev/Phonon-Framework/issues/44)
+* progress bar are not showing sometimes in notifications [#46](https://github.com/quark-dev/Phonon-Framework/issues/46)
+* events inside tabs are not working (on create callback) [#52](https://github.com/quark-dev/Phonon-Framework/issues/52)
+
 ### 1.1.3 (2015-12-06)
 
 #### Bug Fixes

diff --git a/dist/css/components/side-panels.css b/dist/css/components/side-panels.css
@@ -12,6 +12,9 @@
   background-color: #333;
   transition: width 0.3s ease;
 }
+.side-panel .list {
+  overflow-y: auto;
+}
 .side-panel .list li {
   border-color: #444;
 }

diff --git a/dist/css/components/side-panels.min.css b/dist/css/components/side-panels.min.css
diff --git a/dist/css/phonon-base.css b/dist/css/phonon-base.css
@@ -161,8 +161,14 @@ th {
 *:after {
   box-sizing: border-box;
 }
+html,
+body {
+  position: relative;
+  height: 100%;
+  width: 100%;
+  overflow-x: hidden;
+}
 html {
-  overflow: hidden;
   -ms-touch-action: pan-y;
   touch-action: pan-y;
 }
@@ -171,7 +177,6 @@ body {
   right: 0;
   bottom: 0;
   left: 0;
-  overflow: hidden;
   margin: 0;
   padding: 0;
   word-wrap: break-word;

diff --git a/dist/css/phonon-base.min.css b/dist/css/phonon-base.min.css
diff --git a/dist/css/phonon.css b/dist/css/phonon.css
@@ -161,8 +161,14 @@ th {
 *:after {
   box-sizing: border-box;
 }
+html,
+body {
+  position: relative;
+  height: 100%;
+  width: 100%;
+  overflow-x: hidden;
+}
 html {
-  overflow: hidden;
   -ms-touch-action: pan-y;
   touch-action: pan-y;
 }
@@ -171,7 +177,6 @@ body {
   right: 0;
   bottom: 0;
   left: 0;
-  overflow: hidden;
   margin: 0;
   padding: 0;
   word-wrap: break-word;
@@ -1548,6 +1553,9 @@ table,
   background-color: #333;
   transition: width 0.3s ease;
 }
+.side-panel .list {
+  overflow-y: auto;
+}
 .side-panel .list li {
   border-color: #444;
 }

diff --git a/dist/css/phonon.min.css b/dist/css/phonon.min.css
diff --git a/dist/js/components/notifications.js b/dist/js/components/notifications.js
@@ -41,7 +41,7 @@
 
 				window.setTimeout(function() {
 					hide(self);
-				}, timeout);
+				}, parseInt(timeout));
 			}
 		}
 
@@ -54,7 +54,7 @@
 
 		// reset
 		self.style.zIndex = 18;
-		
+
 		var height = self.clientHeight;
 
 		// for the notif
@@ -102,7 +102,7 @@
 		}
 		return -1;
 	}
-	
+
 	var getNotification = function(target) {
 		for (; target && target !== document; target = target.parentNode) {
 			if(target.classList.contains('notification')) {
@@ -115,10 +115,10 @@
 		if(typeof text !== 'string') text = '';
 		timeout = (typeof timeout === 'number' ? timeout : 5000);
 
-        var progress = '<div class="progress"><div class="determinate"></div></div>';
-        var btn = (showButton === true ? '<button class="btn pull-right" data-hide-notif="true">CANCEL</button>' : '');
+    var progress = '<div class="progress"><div class="determinate"></div></div>';
+    var btn = (showButton === true ? '<button class="btn pull-right" data-hide-notif="true">CANCEL</button>' : '');
 
-        var div = document.createElement('div');
+    var div = document.createElement('div');
 		div.setAttribute('class', 'notification');
 		div.setAttribute('data-autodestroy', 'true');
 		if(timeout) div.setAttribute('data-timeout', timeout);
@@ -150,11 +150,11 @@
 		if(!notification.classList.contains('show')) {
 			notification.classList.add('show');
 
-			// Fix animation			
+			// Fix animation
 			notification.style.zIndex = (18 + notifs.length);
 
 			// Fix space
-			
+
 			var value = 0;
 			if(notifs.length > 0) {
 				var lastNotif = notifs[notifs.length - 1];
@@ -187,7 +187,7 @@
 		if(notification.classList.contains('show')) {
 
 			notification.classList.remove('show');
-			
+
 			notification.on(phonon.event.transitionEnd, onHide, false);
 
 			// put floating actions back in their place
@@ -210,7 +210,7 @@
 			var nBuild = buildNotif(text, timeout, showButton);
 			window.setTimeout(function() {
 				show(document.querySelector('#'+nBuild.id));
-			}, 1);
+			}, 10);
 			return;
 		}
 
@@ -237,4 +237,4 @@
 		define(function() { return phonon.notif });
 	}
 
-}(typeof window !== 'undefined' ? window : this, window.phonon || {}));
+}(typeof window !== 'undefined' ? window : this, window.phonon || {}));
diff --git a/dist/js/components/notifications.min.js b/dist/js/components/notifications.min.js
diff --git a/dist/js/components/side-panels.js b/dist/js/components/side-panels.js
@@ -778,8 +778,18 @@
         document.off(phonon.event.end, onBackdrop);
     }
 
+    function onSidebar(target) {
+        var isSidebar = false;
+        for (; target && target !== document; target = target.parentNode) {
+            if (target.classList.contains('side-panel')) {
+                isSidebar = true;
+                break;
+            }
+        }
+        return isSidebar;
+    }
 
-    document.on('tap', function(evt) {
+    document.on(phonon.event.tap, function(evt) {
 
         var target = evt.target;
         var sidebarId = target.getAttribute('data-side-panel-id');
@@ -810,7 +820,7 @@
             }
         }
     });
-
+    
     var onBackdrop = function(evt) {
 
         var target = evt.target;