Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Numeric custom options reported incorrectly #19

Open
martinthomson opened this issue Feb 12, 2013 · 0 comments
Open

Numeric custom options reported incorrectly #19

martinthomson opened this issue Feb 12, 2013 · 0 comments

Comments

@martinthomson
Copy link

Numeric values apply correctly, but are reported as booleans:

[jshint] Using custom options:...,maxcomplexity=false,...

Which isn't constructive.

The output does not need to be so verbose on success, only on failure. All I need to know is that N files were OK, and perhaps where those files were. All this extra stuff that gets printed isn't very useful. I'm also perfectly happy that .jshintrc was not found and don't need to be reminded every time.
codecop added a commit to codecop/ant-jshint that referenced this issue Jun 29, 2013
@codecop
Improve error reporting in case of invalid json options file, change
d67fafb 
options to Map<Object, Object> instead of Properties because wrong
methods were called on Properties. The properties is only used for the
load method, so outside it can be a Map. This solves Issue philmander#19 and Issue
philmander#24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@martinthomson