Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Namespaceify Core #11

Open
clphillips opened this issue Jan 7, 2015 · 3 comments
Open

Namespaceify Core #11

clphillips opened this issue Jan 7, 2015 · 3 comments
Milestone

Comments

@clphillips
Copy link
Contributor

Add namespace support for core.

Increase PHP requirement to 5.3+

@clphillips clphillips added this to the v2.0.0 milestone Jan 7, 2015
@clphillips clphillips modified the milestones: v2.0.0, v1.0.0 Feb 21, 2015
@Feathur
Copy link

Feathur commented Jul 3, 2015

@clphillips
Copy link
Contributor Author

Thanks @Feathur. Unfortunately I won't be able to use the contribution for a few reasons:

  1. Namespace integration has already begun on the 1.0 branch (see 33aaa39).
  2. For 1.0 the framework is being decomposed into independent libraries, and bridged over for backwards compatibility with version 0.x.
  3. One issue you may wish to correct in your commit, is the use of multiple root namespaces. For example, you put Model in Lib\Model. A better choice might be Minphp\Lib\Model (essentially everything in minphp should live behind Minphp\). As I said the framework is being decomposed, so Model will end up in Minphp\Mvc\Model -- part of a totally independent library.

@Feathur
Copy link

Feathur commented Jul 4, 2015

That's perfectly fine. My partner asked that we make the offer, but we had no expectation that you'd want to use it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant