Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local find bar for sites that don't handle ctrl+f #7293

Open
sardination opened this issue Sep 21, 2022 · 1 comment
Open

Local find bar for sites that don't handle ctrl+f #7293

sardination opened this issue Sep 21, 2022 · 1 comment
Labels
bug Something isn't working priority-4-medium #4 Priority - An important, non-blocking issue 📁 Repo: hybrid This PR/Issue modifies /hybrid code

Comments

@sardination
Copy link
Contributor

sardination commented Sep 21, 2022

Feature Description
We want the find bar to behave like it does on a fully local browser. This means that ctrl+f should open a local browser find bar unless the page itself intercepts a ctrl+f and has its own find bar (like Google Docs).

The Problem It Fixes
Currently, the <whist> tag unconditionally grabs ctrl+f and so the find bar that is shown is in the streamed window from the server.

Potential Implementation(s)
We would need to roughly follow these steps:

  1. Grab the find contents of the find bar
  2. Send find contents over to server
  3. Do the search on the server without showing the find bar

We would also have to allow pages that already intercept the find bar (like Google Docs) to continue to do that.

@philippemnoel
Copy link
Owner

Capture d’écran, le 2022-10-11 à 17 44 20

@philippemnoel philippemnoel added bug Something isn't working priority-4-medium #4 Priority - An important, non-blocking issue 📁 Repo: hybrid This PR/Issue modifies /hybrid code labels Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority-4-medium #4 Priority - An important, non-blocking issue 📁 Repo: hybrid This PR/Issue modifies /hybrid code
Projects
None yet
Development

No branches or pull requests

2 participants